feat: Implement add-value-config command and ADR for custom config paths #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the add-value-config command, which allows users to define a new value configuration with metadata. Changes Made: - Implemented AddValueConfigCommand class with proper validation and error handling - Updated CLI to register the new command with appropriate options - Added unit tests with mocks to test the command logic in isolation - Added integration tests to verify file writing and structure - Updated tasks.md to mark the task as completed Testing Done: - Added unit tests with 100% code coverage - Added integration tests that verify the command works in a real environment - Manually tested the command with various options and edge cases Type of Change: Feature Breaking Change: No
Added unit tests for the add-value-config CLI function to improve test coverage: - Test for successful addition of a value configuration - Test for handling duplicate paths - Test for handling empty paths These tests ensure that the CLI interface for the add-value-config command works correctly and handles error cases appropriately.
- Added ADR-009 for supporting custom configuration file paths - Created a separate ADR template file - Updated README.md to reference the template file - Moved 'Creating New ADRs' section to the top of README.md
Updated the ADR to reference GitHub issue #17 for the custom configuration file paths feature.
…ation update and merge feature
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related to #17
Changes Made
add-value-configcommand to allow users to define new value configurations with metadataTesting Done
Checklist
Type of Change
Breaking Change
Additional Information
The
add-value-configcommand allows users to define new value configurations with metadata such as description, whether it's required, and whether it's sensitive. This is a key feature for managing Helm values and follows the design outlined in the sequence diagrams and low-level design documents.Additionally, this PR includes an ADR for a future enhancement to support custom configuration file paths, which will provide more flexibility for users.